Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 3.5 support #374

Merged
merged 5 commits into from
Mar 18, 2021

Conversation

codeboten
Copy link
Contributor

Description

Fixes open-telemetry/opentelemetry-python#1706

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

@codeboten codeboten requested review from a team, owais and hectorhdzg and removed request for a team March 18, 2021 04:01
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs that remove code is so beautiful :) LGTM

if check:
subprocess.check_call(*args, **kwargs)
return CompletedProcess(returncode=0)
return CompletedProcess(returncode=subprocess.call(*args, **kwargs))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lzchen lzchen merged commit ef0f74e into open-telemetry:main Mar 18, 2021
nstawski pushed a commit to nstawski/ns-opentelemetry-python-contrib that referenced this pull request May 10, 2023
…pen-telemetry#615)

The prepare-release workflow is triggered when a new release/<version> branch
is created. This workflow parses the <version> number from the branch name and
updates version.py/changelog.md files accordingly. It then creates a pull
request with those changes.

This addresses part of open-telemetry#374.

Co-authored-by: Mauricio Vásquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants