Remove unnecessary configuration of logs exporter in Gen AI samples #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
github-actions
bot
assigned alizenhom, codefromthecrypt, gyliu513, karthikscale3, lmolkova, lzchen and nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
aabmass
force-pushed
the
no-logs-exporter
branch
from
efd7190 to
49e21ef
Compare
xrmx
approved these changes
Dec 23, 2024
|
@gyliu513 I think you added a comment instead of approving |
gyliu513
approved these changes
Dec 23, 2024
It is no longer necessary since we now set up the logging pipeline by default with OTLP exporter.
aabmass
force-pushed
the
no-logs-exporter
branch
from
49e21ef to
898b26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is no longer necessary, since #3042 we now set up the logging pipeline by default with OTLP exporter.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested the OpenAI zero code sample with Ollama and verified logs were sent to local OTLP endpoint.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.