Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move AwsLambdaInstrumentor().instrument() to after the lambda function #3085

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Kludex
Copy link
Contributor

@Kludex Kludex commented Dec 10, 2024

#2056 (comment)

tox -e docs doesn't work...

        File "/private/var/folders/q1/wn12m6td0tx0dy1s84xzrxbm0000gn/T/pip-install-nycnab7m/mysqlclient_22dcb881261f49e7b709df7ab13fc6ed/setup_posix.py", line 31, in mysql_config
          raise OSError("{} not found".format(_mysql_config_path))
      OSError: mysql_config not found
      [end of output]

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 11, 2024
@emdneto
Copy link
Member

emdneto commented Dec 11, 2024

@Kludex I think tox—e docs needs some packages installed at the host level, like mysql_config. When running at CI, it works without any issue because it already has the package, so it's not a problem with the command itself.

@Kludex
Copy link
Contributor Author

Kludex commented Dec 11, 2024

mysql_config

I got that, but where's the instruction?

@xrmx xrmx merged commit d2a51b9 into open-telemetry:main Dec 11, 2024
573 checks passed
@Kludex Kludex deleted the change-instrument-location branch December 11, 2024 15:03
@xrmx
Copy link
Contributor

xrmx commented Dec 11, 2024

mysql_config

I got that, but where's the instruction?

It's one PR away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants