Add type hints to psycopg
#3067
Open
+45
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a docstring error? |
Kludex
commented
Dec 12, 2024
Comment on lines
+121
to
+124
| ConnectionT = TypeVar( | ||
| "ConnectionT", psycopg.Connection, psycopg.AsyncConnection | ||
| ) | ||
| CursorT = TypeVar("CursorT", psycopg.Cursor, psycopg.AsyncCursor) |
There was a problem hiding this comment.
We want to make sure that the output value of a function that accepts ConnectionT is also a ConnectionT... Doing what I'm doing here, I'm telling the type checker if the class is a psycopg.Connection, the output will be a psycopg.Connection. That's why we don't use Unions here.
|
Anything I can do to speed up the review process here? @xrmx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-instrumentation-psycopgclaims to work for async queries, but doesn't record time #2486.