Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI instrumentation docs fixes #2988

Merged
merged 17 commits into from
Dec 2, 2024
Merged

OpenAI instrumentation docs fixes #2988

merged 17 commits into from
Dec 2, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 9, 2024 •
edited
Loading

@lmolkova lmolkova requested a review from a team as a code owner November 9, 2024 02:06
@lmolkova lmolkova mentioned this pull request Nov 9, 2024
Open
3 tasks
@alizenhom alizenhom mentioned this pull request Nov 9, 2024
Merged
8 tasks
@lmolkova lmolkova mentioned this pull request Nov 10, 2024
Merged
@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 12, 2024
@lmolkova lmolkova force-pushed the openai-docs-fixes branch 2 times, most recently from 2299149 to 26c92b5 Compare November 21, 2024 04:26
lzchen
lzchen requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.

@lmolkova lmolkova mentioned this pull request Nov 22, 2024
Merged
8 tasks
@codefromthecrypt
Copy link
Contributor

fyi an end user just noticed the 404 which I think this aims to fix. is there anything left that needs help on?

@xrmx
Copy link
Contributor

xrmx commented Dec 2, 2024 •
edited
Loading

Merging main to check if we need to pin httpx<0.28.0 also for new openai versions

@xrmx xrmx merged commit 142b86c into open-telemetry:main Dec 2, 2024
573 checks passed
@codefromthecrypt
Copy link
Contributor

IIUC, the link fix is coupled to the latest version in pypi, so it won't correct until the next release, right?

@xrmx
Copy link
Contributor

xrmx commented Dec 2, 2024

IIUC, the link fix is coupled to the latest version in pypi, so it won't correct until the next release, right?

Yeah, changes to pyproject.toml will be available in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasiths dasiths dasiths approved these changes

@gyliu513 gyliu513 gyliu513 left review comments

@codefromthecrypt codefromthecrypt codefromthecrypt left review comments

@alizenhom alizenhom alizenhom approved these changes

@karthikscale3 karthikscale3 karthikscale3 approved these changes

@lzchen lzchen lzchen approved these changes

@nirga nirga Awaiting requested review from nirga

Assignees

@codefromthecrypt codefromthecrypt

@lmolkova lmolkova

@nirga nirga

@gyliu513 gyliu513

@lzchen lzchen

@karthikscale3 karthikscale3

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lmolkova @codefromthecrypt @xrmx @gyliu513 @lzchen @dasiths @karthikscale3 @alizenhom @nirga