Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gyliu513 as genai reviewer #2972

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

gyliu513
Copy link
Member

@gyliu513 gyliu513 commented Nov 7, 2024

Description

/cc @lmolkova @lzchen

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@gyliu513 gyliu513 requested a review from a team as a code owner November 7, 2024 18:28
@karthikscale3
Copy link
Contributor

@gyliu513 - i think you need to update the changelog

@gyliu513
Copy link
Member Author

gyliu513 commented Nov 7, 2024

There is no changelog for this.

@karthikscale3
Copy link
Contributor

There is no changelog for this.

ok not sure why the changelog test is failing though.

@gyliu513
Copy link
Member Author

gyliu513 commented Nov 7, 2024

@karthikscale3 are you able to add "Skip Changelog" label for this? If not, I think @lmolkova or @lzchen may help, thanks!

From https://github.com/open-telemetry/opentelemetry-python-contrib
 * branch            main       -> FETCH_HEAD
 * [new branch]      main       -> origin/main
No CHANGELOG was modified.
Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.
Error: Process completed with exit code 1.

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 7, 2024
@lzchen lzchen merged commit 46b1466 into open-telemetry:main Nov 8, 2024
566 checks passed
@gyliu513 gyliu513 deleted the genai branch November 8, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants