opentelemetry-instrumentation: don't fail if an instrumentor raises ImportError #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mportError Treat instrumentor loading raising ImportError different than the other exceptions. In scenarios using the kubernetes operator to do autoinstrumentation some instrumentors may fail to load (usually requiring binary extensions) because the injected autoinstrumentation code does not match the application environment regarding python version, libc, etc... In this case it's better to skip the single instrumentation rather than failing to load everything so treat differently ImportError than the rest of exceptions.
xrmx
commented
Oct 23, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/_load.py
Outdated
Show resolved
Hide resolved
…n/auto_instrumentation/_load.py
emdneto
approved these changes
Oct 23, 2024
lzchen
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Treat instrumentor loading raising ImportError different than the other exceptions.
In scenarios using the kubernetes operator to do autoinstrumentation some instrumentors (usually requiring binary extensions) may fail to load because the injected autoinstrumentation code does not match the application environment regarding python version, libc, etc... In this case it's better to skip the single instrumentation rather than failing to load everything so treat differently ImportError than the rest of exceptions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.