Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shellcheck and docker-tests in CI #2905

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Oct 15, 2024

It seems Ubuntu changed the image, which is breaking spellcheck and docker-tests. Fixing that.

See: https://github.com/open-telemetry/opentelemetry-python/actions/runs/11346063440/job/31554334634 and the Ci for the first commit in this PR

Signed-off-by: emdneto <[email protected]>
@emdneto emdneto requested a review from a team as a code owner October 15, 2024 15:03
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 15, 2024
@emdneto emdneto changed the title test shellcheck fix: shellcheck CI Oct 15, 2024
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto changed the title fix: shellcheck CI fix: shellcheck and docker-tests in CI Oct 15, 2024
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
@lzchen lzchen merged commit d7d7e96 into open-telemetry:main Oct 15, 2024
1055 checks passed
znd4 pushed a commit to znd4/opentelemetry-python-contrib that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants