Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eachdist and move tox to root folder #29

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Add eachdist and move tox to root folder #29

merged 2 commits into from
Apr 9, 2020

Conversation

mauriciovasquezbernal
Copy link
Member

Move tox and other configuration files to root folder. Add eachdist to make it
easier to handle operations with different packages.

The eachdist is taken from opentelemetry but slighty modified to avoid ignoring
a given path.

@mauriciovasquezbernal mauriciovasquezbernal requested a review from a team April 8, 2020 22:12
Move tox and other configuration files to root folder. Add eachdist to make it
easier to handle operations with different packages.

The eachdist is taken from opentelemetry but slighty modified to avoid ignoring
a given path.
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of changes to not look for directories that are specific to the opentelemetry-python repo. note: this could be a good opportunity to make the scripts a bit more generic


coverage erase

cov opentelemetry-api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely need changing here

pyproject.toml Outdated
(
/( # generated files
docs/examples/opentelemetry-example-app/src/opentelemetry_example_app/grpc/gen|
ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/gen|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably dont need the docs and ext lines in here

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeboten codeboten merged commit fc4620c into open-telemetry:master Apr 9, 2020
NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this pull request Oct 17, 2020
…ry#29)

* Global tracer registry: First somewhat satisfying iteration.

* Add API docs for backend module

* Fix documentation (and overlong lines within).

* Sort imports.

* Remove _UNIT_TEST_IGNORE_ENV.

We should be able to ensure clean envvars for the test run.

* Misc cleanup.

* Fix backend.py not being included in wheel.

* Rewrite backend/loader.

* Rewrite backend/loader more, fix pylint, mypy.

* Ditch 'default' in `_load_default_impl`, it's just wrong now.

* Fix docs.

* Apply new package structure.

* Remove unit tests (for now).

* Document the factory type aliases.

* Store factory functions in respective modules.

Gets rid of the dictionary in loader.py.

* Fix factory return type (Optional) & improve docs.

* Revert accidental changes to setup.py.

* Remove unused global.
NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this pull request Oct 20, 2020
Move tox and other configuration files to root folder. Add eachdist to make it
easier to handle operations with different packages.

The eachdist is taken from opentelemetry but slighty modified to avoid ignoring
a given path.
NathanielRN pushed a commit to NathanielRN/opentelemetry-python-contrib-1 that referenced this pull request Oct 23, 2020
Move tox and other configuration files to root folder. Add eachdist to make it
easier to handle operations with different packages.

The eachdist is taken from opentelemetry but slighty modified to avoid ignoring
a given path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants