-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eachdist and move tox to root folder #29
Add eachdist and move tox to root folder #29
Conversation
Move tox and other configuration files to root folder. Add eachdist to make it easier to handle operations with different packages. The eachdist is taken from opentelemetry but slighty modified to avoid ignoring a given path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of changes to not look for directories that are specific to the opentelemetry-python repo. note: this could be a good opportunity to make the scripts a bit more generic
scripts/coverage.sh
Outdated
|
||
coverage erase | ||
|
||
cov opentelemetry-api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will likely need changing here
pyproject.toml
Outdated
( | ||
/( # generated files | ||
docs/examples/opentelemetry-example-app/src/opentelemetry_example_app/grpc/gen| | ||
ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/gen| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably dont need the docs and ext lines in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ry#29) * Global tracer registry: First somewhat satisfying iteration. * Add API docs for backend module * Fix documentation (and overlong lines within). * Sort imports. * Remove _UNIT_TEST_IGNORE_ENV. We should be able to ensure clean envvars for the test run. * Misc cleanup. * Fix backend.py not being included in wheel. * Rewrite backend/loader. * Rewrite backend/loader more, fix pylint, mypy. * Ditch 'default' in `_load_default_impl`, it's just wrong now. * Fix docs. * Apply new package structure. * Remove unit tests (for now). * Document the factory type aliases. * Store factory functions in respective modules. Gets rid of the dictionary in loader.py. * Fix factory return type (Optional) & improve docs. * Revert accidental changes to setup.py. * Remove unused global.
Move tox and other configuration files to root folder. Add eachdist to make it easier to handle operations with different packages. The eachdist is taken from opentelemetry but slighty modified to avoid ignoring a given path.
Move tox and other configuration files to root folder. Add eachdist to make it easier to handle operations with different packages. The eachdist is taken from opentelemetry but slighty modified to avoid ignoring a given path.
Move tox and other configuration files to root folder. Add eachdist to make it
easier to handle operations with different packages.
The eachdist is taken from opentelemetry but slighty modified to avoid ignoring
a given path.