Audit and test opentelemetry-instrumentation-fastapi NoOpTracerProvider #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
emdneto
reviewed
Aug 6, 2024
lzchen
approved these changes
Aug 6, 2024
emdneto
approved these changes
Aug 7, 2024
Signed-off-by: Qiu, David <[email protected]>
qiuge615
force-pushed
the
audit-and-test-opentelemetry-instrumentation-fastapi-no-op-tracer
branch
from
4aaadf8 to
4fe9dda
Compare
|
@emdneto Thanks for your suggestions, rebased the PR, please review, thanks. |
qiuge615
deleted the
audit-and-test-opentelemetry-instrumentation-fastapi-no-op-tracer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for Fastapi using NoOpTracerProvider
#982
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Instrument the library using a NoOpTracerProvider. The test validates that no spans are being produced.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.