Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aws lambda sqs #2766

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mlorenzana
Copy link

@mlorenzana mlorenzana commented Jul 31, 2024

Description

Updated default context extractor to also pull from sqs record message attributes under certain conditions.

Fixes #2764

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_parent_context_from_lambda_event - TestCase sqs_single_record

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jul 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mlorenzana mlorenzana force-pushed the feature/aws-lambda-sqs branch from f85f36b to 9539e7c Compare July 31, 2024 19:20
@xrmx
Copy link
Contributor

xrmx commented Aug 5, 2024

Since you need to rebase I'd say wait for #2760 to land

@CarissaThomas
Copy link

Is it possible to get this merged in? Would be extremely helpful for tracing with AWS Python Lambdas. Thanks!

@mlorenzana
Copy link
Author

@CarissaThomas @xrmx I added in the test changes, there doesn't seem to be an owner of this component so I'm not really sure who to get approval from..

@mlorenzana mlorenzana requested a review from a team as a code owner December 4, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpret TraceParent from non-http lambda events
3 participants