instrumentation/fastapi: fix fastapi-slim support #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
fix-fastapi-slim-handling
branch
from
6f0fa1a to
96e6cc9
Compare
xrmx
force-pushed
the
fix-fastapi-slim-handling
branch
from
96e6cc9 to
2af7311
Compare
xrmx
force-pushed
the
fix-fastapi-slim-handling
branch
from
2af7311 to
5febb55
Compare
emdneto
reviewed
Jul 31, 2024
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Outdated
Show resolved
Hide resolved
Closed
11 tasks
emdneto
approved these changes
Jul 31, 2024
lzchen
reviewed
Jul 31, 2024
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Jul 31, 2024
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Outdated
Show resolved
Hide resolved
Merged
8 tasks
In instrumentation_dependencies we need to use pkg_resources.get_distribution
because find_spec("fastapi") will return something even with just fastapi-slim
installed.
Then need to fix the tox environment name otherwise all the fastapi
dependencies will also be installed for fastapi-slim and tests would
pass because they find fastapi installed.
xrmx
force-pushed
the
fix-fastapi-slim-handling
branch
from
d42b9bf to
c454847
Compare
lzchen
approved these changes
Aug 1, 2024
|
It seems the tests for fastapislim aren't being run in CI. Checked the job and is only installing the packages 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In instrumentation_dependencies we need to use importlib.metadata.distribution because find_spec("fastapi") will return something even with just fastapi-slim installed.
Then need to fix the tox environment name otherwise all the fastapi dependencies will also be installed for fastapi-slim and tests would pass because they find fastapi installed.
Fixes #2683
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.