-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mysql): add support for mysql-connector-python v9 #2751
Merged
lzchen
merged 10 commits into
open-telemetry:main
from
omikader:support-mysql-connector-9
Jul 31, 2024
Merged
feat(mysql): add support for mysql-connector-python v9 #2751
lzchen
merged 10 commits into
open-telemetry:main
from
omikader:support-mysql-connector-9
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omikader
force-pushed
the
support-mysql-connector-9
branch
from
July 29, 2024 15:56
ca401c3
to
6db9dcc
Compare
xrmx
reviewed
Jul 29, 2024
omikader
force-pushed
the
support-mysql-connector-9
branch
from
July 29, 2024 16:57
ee98e04
to
9fddfdc
Compare
xrmx
approved these changes
Jul 30, 2024
emdneto
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think would be nice a changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for
mysql-connector-python
v9.Fixes #2720
Type of change
How Has This Been Tested?
Ran unit tests locally on the new version
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.