Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue opentelemetry-instrumentation-asgi: do not set url.full attribute for server spans #2735

Merged
merged 14 commits into from
Aug 14, 2024
Merged

Fix issue opentelemetry-instrumentation-asgi: do not set url.full attribute for server spans #2735

merged 14 commits into from
Aug 14, 2024

Conversation

shijiadong2022
Copy link
Contributor

@shijiadong2022 shijiadong2022 commented Jul 24, 2024 •
edited by xrmx
Loading

Description

Fixes #2698

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 24, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@brianwarner brianwarner force-pushed the fix-jinja2-template branch from b719b22 to c758f67 Compare July 25, 2024 12:22
emdneto
emdneto reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a Changelog entry for this?

@brianwarner brianwarner force-pushed the fix-jinja2-template branch from 43eeddd to 001165f Compare July 31, 2024 20:55
@brianwarner brianwarner requested a review from a team July 31, 2024 20:55
@shijiadong2022
fix issue 2698
0a3a8e7 
Signed-off-by: Shi, Stone <[email protected]>
@shijiadong2022
revert back to shared method
e547ecd 
Signed-off-by: Shi, Stone <[email protected]>
@emdneto emdneto marked this pull request as draft August 1, 2024 12:18
@shijiadong2022 shijiadong2022 marked this pull request as ready for review August 1, 2024 12:50
@qiuge615 qiuge615 mentioned this pull request Aug 6, 2024
Open
@brianwarner brianwarner force-pushed the fix-jinja2-template branch from f726192 to 3385bb0 Compare August 6, 2024 12:08
@shijiadong2022
Copy link
Contributor Author

@emdneto all checks have passed now. Can you take a look when you get a chance?

lzchen
lzchen reviewed Aug 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@shijiadong2022 shijiadong2022 requested a review from emdneto August 14, 2024 01:14
@lzchen lzchen merged commit af9e841 into open-telemetry:main Aug 14, 2024
521 checks passed
@alexmojaki alexmojaki mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentelemetry-instrumentation-asgi: do not set url.full attribute for server spans
3 participants
@shijiadong2022 @emdneto @lzchen