Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing requirements and test processor baggage in CI #2717

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 17, 2024

Fixes #2716

@ocelotl ocelotl self-assigned this Jul 17, 2024
@ocelotl ocelotl requested a review from a team July 17, 2024 01:39
@github-actions github-actions bot requested a review from codeboten July 17, 2024 01:40
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 17, 2024
@xrmx
Copy link
Contributor

xrmx commented Jul 17, 2024

Is the package missing a dependency in pyproject to the sdk?

@xrmx xrmx self-requested a review July 17, 2024 20:03
@xrmx
Copy link
Contributor

xrmx commented Jul 22, 2024

@codeboten PTAL
cc @MikeGoldsmith

@xrmx
Copy link
Contributor

xrmx commented Jul 23, 2024

@ocelotl Could you please add this while at it? It is importing the SpanProcessor from sdk

diff --git a/processor/opentelemetry-processor-baggage/pyproject.toml b/processor/opentelemetry-processor-baggage/pyproject.toml
index 3fa80e15..29fc2e86 100644
--- a/processor/opentelemetry-processor-baggage/pyproject.toml
+++ b/processor/opentelemetry-processor-baggage/pyproject.toml
@@ -26,6 +26,7 @@ classifiers = [
 ]
 dependencies = [
   "opentelemetry-api ~= 1.5",
+  "opentelemetry-sdk ~= 1.5",
   "wrapt >= 1.0.0, < 2.0.0",
 ]
 

BTW cannot test this package locally:

tox -e py310-test-processor-baggage
...
py310-test-processor-baggage: failed with pytest is not allowed, use allowlist_externals to allow it

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 24, 2024

@ocelotl Could you please add this while at it? It is importing the SpanProcessor from sdk

diff --git a/processor/opentelemetry-processor-baggage/pyproject.toml b/processor/opentelemetry-processor-baggage/pyproject.toml
index 3fa80e15..29fc2e86 100644
--- a/processor/opentelemetry-processor-baggage/pyproject.toml
+++ b/processor/opentelemetry-processor-baggage/pyproject.toml
@@ -26,6 +26,7 @@ classifiers = [
 ]
 dependencies = [
   "opentelemetry-api ~= 1.5",
+  "opentelemetry-sdk ~= 1.5",
   "wrapt >= 1.0.0, < 2.0.0",
 ]
 

Right, added it.

BTW cannot test this package locally:

tox -e py310-test-processor-baggage
...
py310-test-processor-baggage: failed with pytest is not allowed, use allowlist_externals to allow it

Weird, should be working pytest is already in test-requiremnets.txt (I also just tried locally and can run the tests).

@ocelotl ocelotl merged commit dbfa681 into open-telemetry:main Jul 29, 2024
389 checks passed
@ocelotl ocelotl deleted the issue_2716 branch July 29, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processor baggage is missing test requirements
4 participants