Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update process metric name #2706

Closed

Conversation

arunk1988
Copy link

@arunk1988 arunk1988 commented Jul 13, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2662

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -f py38-system-metrics

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@arunk1988
Copy link
Author

@emdneto I would like to open a PR from my organizational account, which does not support maintainer commits. Please consider this PR a draft for review and correction

@arunk1988 arunk1988 marked this pull request as ready for review July 15, 2024 16:53
…rc/opentelemetry/instrumentation/system_metrics/__init__.py

Co-authored-by: Emídio Neto <[email protected]>
@arunk1988 arunk1988 marked this pull request as draft July 16, 2024 06:22
@emdneto
Copy link
Member

emdneto commented Jul 31, 2024

superseded by #2727

@emdneto emdneto closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OS process metrics name according to semconv
2 participants