Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sync and async test guide at contributing.md #2694

Merged
merged 3 commits into from
Jul 11, 2024
Merged

add sync and async test guide at contributing.md #2694

merged 3 commits into from
Jul 11, 2024

Conversation

zhihali
Copy link
Contributor

@zhihali zhihali commented Jul 10, 2024

Description

fix #2684

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

do not need to

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@zhihali zhihali requested a review from a team July 10, 2024 23:45
xrmx
xrmx reviewed Jul 11, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 11, 2024
@zhihali @xrmx
Update CONTRIBUTING.md
45375c9 
Co-authored-by: Riccardo Magliocchetti <[email protected]>
xrmx
xrmx approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lzchen lzchen merged commit 43dfc73 into open-telemetry:main Jul 11, 2024
379 checks passed
@zhihali zhihali deleted the patch-1 branch July 11, 2024 16:38
@zhihali zhihali mentioned this pull request Jul 16, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add sync and async test guide at contributing.md
4 participants
@zhihali @xrmx @emdneto @lzchen