Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty statement in psycopg instrumentation #2644

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Handle empty statement in psycopg instrumentation #2644

merged 6 commits into from
Jul 2, 2024

Conversation

Holi0317
Copy link
Contributor

@Holi0317 Holi0317 commented Jun 28, 2024 •
edited
Loading

Fixes #2643

Description

Handle case where statement can be empty in psycopg

Fixes #2643

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unit test cases for empty string query

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from federicobond June 28, 2024 00:51
@Holi0317 Holi0317 requested a review from a team June 28, 2024 00:52
@xrmx
Copy link
Contributor

xrmx commented Jun 28, 2024

Nice catch!

@Holi0317 Holi0317 requested a review from xrmx June 30, 2024 16:51
@lzchen lzchen merged commit 9021148 into open-telemetry:main Jul 2, 2024
365 checks passed
@Holi0317 Holi0317 deleted the bugfix-2643 branch July 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@xrmx xrmx xrmx approved these changes

@federicobond federicobond Awaiting requested review from federicobond

Assignees

@federicobond federicobond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Psycopg: Exception when running conn.execute("")
4 participants
@Holi0317 @xrmx @lzchen @federicobond