Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(async-io): return coro when __name__ is not present #2541

Merged
merged 1 commit into from
May 23, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented May 22, 2024

Description

Fixes #2340

Seems to be we need to return coro when name is not present as per #2521 (comment)

Though demo app and unit test works in both cases 🤔

I guess it's still better for consistency

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Running:

Installing dev dependency and running:
python3 anext.py

from the issue - #2340

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@povilasv povilasv marked this pull request as ready for review May 22, 2024 14:47
@povilasv povilasv requested a review from a team May 22, 2024 14:47
CHANGELOG.md Outdated Show resolved Hide resolved
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 23, 2024
@povilasv povilasv force-pushed the fix-coroutine-name2 branch from 2160909 to db33903 Compare May 23, 2024 11:23
@povilasv povilasv requested a review from xrmx May 23, 2024 11:24
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lzchen lzchen merged commit 66a107f into open-telemetry:main May 23, 2024
314 checks passed
@povilasv povilasv deleted the fix-coroutine-name2 branch May 24, 2024 03:10
shadchin pushed a commit to shadchin/opentelemetry-python-contrib that referenced this pull request May 29, 2024
@rrjjvv rrjjvv mentioned this pull request Aug 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'async_generator_asend' object has no attribute '__name__'
3 participants