Fix running async psycopg tests #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
fix-asyncio-unittest-tests
branch
2 times, most recently
from
7b149eb to
10b7965
Compare
xrmx
force-pushed
the
fix-asyncio-unittest-tests
branch
2 times, most recently
from
64f7b48 to
f6eff5b
Compare
|
Will look into this today or tomorrow. |
|
I've tried to debug this a bit and it looks like the wrapped cursor is not used but since everything is mocked it may be just an issue with the mock themselves. |
xrmx
force-pushed
the
fix-asyncio-unittest-tests
branch
from
f6eff5b to
61f94fe
Compare
While at it remove pytes asyncio markers that are not needed when running tests in IsolatedAsyncioTestCase
Tests were not run because the test case did not await on async tests. Split tests in two testcases: one for sync tests and one for async tests.
xrmx
force-pushed
the
fix-asyncio-unittest-tests
branch
from
61f94fe to
10ab86f
Compare
|
The missing bits was an |
lzchen
approved these changes
May 28, 2024
|
Will merge after @federicobond takes a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests were not run because the test case did not await on async tests. Split tests in two testcases: one for sync tests and one for async tests.
This is draft because a test still fails, I've fixed some trivial issues but I'm not a psycopg expert.@federicobond Could you please take a look?
Fixes #2539
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.