-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate lint into several jobs #2467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI black, isort and flake8 can be run once per repository instead of per package, that would avoid duplicating a ton of lines in tox (and also work)
1f65939
to
1638399
Compare
Sure, but I want to produce a scenario as similar as possible to a scenario where there are multiple |
a4ea75f
to
b0e6efc
Compare
Lint tests take ~14 minutes right now: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/8839570393/job/24273211949 This PR speeds up this process to ~2 minutes: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/8862990640 |
I see that, I would had hoped to make lint faster by using faster tools before splitting stuff though. |
Sure, we can move to another tool later, this does not introduce anyting new that needs further CI testing and already makes a huge difference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to sort packages in the matrix though
Right, I just sorted them ✌️ |
Fixes #2419