Fix exception handling for events with requestContext #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
approved these changes
Apr 23, 2024
|
Please add a CHANGELOG entry. |
|
Added CHANGELOG entry. |
xrmx
approved these changes
Apr 24, 2024
xrmx
requested changes
Apr 24, 2024
There was a problem hiding this comment.
@alessandrobologna you added more changelog entries than this PR 😅
alessandrobologna
force-pushed
the
fix-issue-2399
branch
from
4cf1194 to
1c0fffd
Compare
|
@xrmx apologies, this should be fixed now |
ocelotl
approved these changes
Apr 25, 2024
|
👋 Hey, we've just run into this issue. Is it possible a new release can be made soon that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Lambda invocations with an event that contains a
requestContextproperty, the current code throws anUnboundLocalErrorif an exception (of other type) is thrown in the function execution, due to theresultvariable being accessed before being initialized. This PR simply makes sure that is initialized before being used.Fixes #2399
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e py38-test-instrumentation-aws-lambdatox -e py39-test-instrumentation-aws-lambdatox -e py310-test-instrumentation-aws-lambdatox -e py311-test-instrumentation-aws-lambdaDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.