Put the xray propagator’s test dep. on requests in the test extra, not just tox.ini #2167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
opentelemetry-propagator-aws-xray
package usesrequests
in its tests,opentelemetry-python-contrib/propagator/opentelemetry-propagator-aws-xray/tests/test_aws_xray_propagator.py
Line 18 in 8fd2105
opentelemetry-python-contrib/propagator/opentelemetry-propagator-aws-xray/tests/performance/benchmarks/test_benchmark_aws_xray_propagator.py
Line 15 in 8fd2105
but lacks a direct dependency on it in the
tests
extra:opentelemetry-python-contrib/propagator/opentelemetry-propagator-aws-xray/pyproject.toml
Lines 30 to 31 in 8fd2105
This has probably not been noticed because there are already test dependencies on
requests
elsewhere in the repository, e.g. inopentelemetry-instrumentation-fastapi
and inopentelemetry-exporter-prometheus-remote-write
, so it ends up installed when testing the repository as a whole.This PR simply adds the missing dependency.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This was considered too trivial to test.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.