Measure http server durations in seconds

[gouthamve]

See: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-metrics.md#metric-httpserverrequestduration

I couldn't figure out how to set the histograms' buckets though :(

Description

The unit for http.server.request.duration should be seconds and not milliseconds.

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

This has not been tested yet. I want to start the discussion around this before doing more work.

• Test A

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[srikanthccv]

I couldn't figure out how to set the histograms' buckets though :(

The advisory API has not been implemented yet.

This has not been tested yet. I want to start the discussion around this before doing more work.

There are existing tests for each instrumentation that should be updated, ex:

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py

Lines 313 to 327 in e318c94

	start = default_timer()
	self.client.post("/hello/756")
	self.client.post("/hello/756")
	self.client.post("/hello/756")
	duration = max(round((default_timer() - start) * 1000), 0)
	metrics_list = self.memory_metrics_reader.get_metrics_data()
	for resource_metric in metrics_list.resource_metrics:
	for scope_metric in resource_metric.scope_metrics:
	for metric in scope_metric.metrics:
	for point in list(metric.data.data_points):
	if isinstance(point, HistogramDataPoint):
	self.assertEqual(point.count, 3)
	self.assertAlmostEqual(
	duration, point.sum, delta=10
	)

Or did you want to discuss something else?

@lzchen I belive this also comes under the transition plan for HTTP semantic conventions update #1768?

[ocelotl]

Please add a CHANGELOG entry.

[lzchen]

@srikanthccv

Based off of this decision, any breaking changes made while upgrading semantic conventions that conflict, we will take the new conventions as priority. The only exceptions to this would be attributes, and we will be implementing the migration plan for those. So this change in particular does not need to do anything special in terms of migration.

[lzchen]

Part of this tracking issue: #1999