Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pymemcache version > 4.0.0 #1764

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

rjduffner
Copy link
Contributor

@rjduffner rjduffner commented Apr 18, 2023

Description

Adds support for pymemcache versions >4.0.0,<5.0.0

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • All current tests pass

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated

@rjduffner rjduffner requested a review from a team April 18, 2023 15:08
@rjduffner rjduffner changed the title Add support for pymemcache version > 4.0.0 [WIP] Add support for pymemcache version > 4.0.0 Apr 18, 2023
@rjduffner rjduffner force-pushed the pymemcache400-support branch from 6001fec to ace3978 Compare April 20, 2023 17:25
@rjduffner rjduffner force-pushed the pymemcache400-support branch from 089c3e2 to 5eaaa7e Compare April 20, 2023 20:26
@rjduffner rjduffner changed the title [WIP] Add support for pymemcache version > 4.0.0 Add support for pymemcache version > 4.0.0 Apr 20, 2023
@rjduffner
Copy link
Contributor Author

@shalevr, would you like me to rebase, seems like the tests are now failing with some aiohttp instrumentation errors. Please let me know If I I need to do anything.

Thanks

@shalevr
Copy link
Member

shalevr commented Apr 24, 2023

@shalevr, would you like me to rebase, seems like the tests are now failing with some aiohttp instrumentation errors. Please let me know If I I need to do anything.

Thanks

Hi, it will be fixed in this PR #1772 , so there is no need to rebase

@srikanthccv srikanthccv merged commit c8b0653 into open-telemetry:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants