Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add latin-1 fallback decoding for asgi headers #1713

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nkhitrov
Copy link

@nkhitrov nkhitrov commented Mar 7, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1478

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nkhitrov / name: Nick Khitrov (a381c2e)

@nkhitrov nkhitrov force-pushed the asgi-header-decoding branch from 8f43c74 to ea26c59 Compare May 4, 2023 02:31
@nkhitrov nkhitrov force-pushed the asgi-header-decoding branch from ea26c59 to a381c2e Compare May 4, 2023 02:42
@nkhitrov nkhitrov changed the title Add latin-1 fallback decoding for asgi headers WIP: Add latin-1 fallback decoding for asgi headers May 4, 2023
@nkhitrov nkhitrov force-pushed the asgi-header-decoding branch from 09eae2a to a381c2e Compare May 4, 2023 03:18
@thomasleveil
Copy link
Contributor

Is there any reason for this PR to stay at the Draft status ?

@lzchen
Copy link
Contributor

lzchen commented Aug 19, 2024

@nkhitrov

Are you still working on this or can someone else pick this up from where you left off?

@nkhitrov
Copy link
Author

@lzchen no, I forget about this issue 😅

I don't mind if someone pick this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentation raises uncaught exception on non utf-8 request header sequences
3 participants