Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test using NoOpTracerProvider - sqlalchemy #1508

Merged
merged 6 commits into from
Jan 1, 2023

Conversation

avzis
Copy link
Contributor

@avzis avzis commented Dec 20, 2022

Description

Add a test for sqlalchemy instrumentation to ensure that NoOpTracerProvider works

Fixes #965

How Has This Been Tested?

  • Instrument the library using a NoOpTracerProvider. the test validates that no spans are being produced.

Does This PR Require a Core Repo Change?

  • No.

@avzis avzis changed the title add a test using NoOpTracerProvider add a test using NoOpTracerProvider - sqlalchemy Dec 20, 2022
@avzis avzis marked this pull request as ready for review December 21, 2022 08:28
@avzis avzis requested a review from a team December 21, 2022 08:28
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 1, 2023
@srikanthccv srikanthccv enabled auto-merge (squash) January 1, 2023 18:04
@srikanthccv srikanthccv merged commit 3461604 into open-telemetry:main Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit and test opentelemetry-instrumentation-sqlalchemy
5 participants