Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for regular expression matching and sanitizing of headers in Starlette. #1404

Merged

Conversation

rogersd
Copy link
Contributor

@rogersd rogersd commented Oct 24, 2022

Next part of #1184

Description

Add test cases for regular expression matching.
Add test cases for header sanitizing.
Add documentation for regular expression matching and header sanitation.
Various documentation cleanups and standardization.

Fixes #1184

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rogersd rogersd requested a review from a team October 24, 2022 18:51
@rogersd rogersd force-pushed the drogers-wildcard-headers-starlette branch 3 times, most recently from 33dbc7b to 7f64e25 Compare October 31, 2022 22:37
@rogersd rogersd force-pushed the drogers-wildcard-headers-starlette branch 3 times, most recently from 6af52e2 to f5abacb Compare November 7, 2022 17:15
@rogersd rogersd force-pushed the drogers-wildcard-headers-starlette branch from 67d6f49 to 1fb6de4 Compare November 10, 2022 20:03
@rogersd rogersd force-pushed the drogers-wildcard-headers-starlette branch from 1fb6de4 to 708406e Compare November 14, 2022 16:45
@srikanthccv srikanthccv enabled auto-merge (squash) November 15, 2022 00:51
@srikanthccv srikanthccv merged commit 868049e into open-telemetry:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features for adding HTTP request / response headers to spans.
2 participants