Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASGI: Capture request/response headers as span attributes #919

Closed
ashu658 opened this issue Feb 11, 2022 · 2 comments
Closed

ASGI: Capture request/response headers as span attributes #919

ashu658 opened this issue Feb 11, 2022 · 2 comments
Assignees
@sanketmehta28
Labels
feature-request

Comments

@ashu658
Copy link
Member

ashu658 commented Feb 11, 2022

part of #906
@sanketmehta28
Copy link
Member

Hi @owais , Can you assign this to me? I had a discussion with @ashu658 . I will look into this issue.

sanketmehta28 added a commit to sanketmehta28/opentelemetry-python-contrib that referenced this issue Mar 17, 2022
@sanketmehta28
code change to add custom http and websocket request and response hea…
6e668aa 
…ders as span attributes. Issue: open-telemetry#919
@sanketmehta28 sanketmehta28 mentioned this issue Mar 17, 2022
Merged
6 tasks
@ashu658 ashu658 removed their assignment Mar 26, 2022
ocelotl pushed a commit that referenced this issue Mar 29, 2022
@sanketmehta28 @lzchen @srikanthccv
code change to add custom http and websocket request and response hea… (
b1bf8d4 
#1004)

* code change to add custom http and websocket request and response headers as span attributes. Issue: #919

* adding entry to changelog

* changes after running "tox -e generate" locally

* - added server_span.is_recording() in _get_otel_send() just to make sure the span is recording before adding the attributes to span.
- changed span to current_span to make sure attributes are being added to proper span.

* removed commented code

Co-authored-by: Leighton Chen <[email protected]>
Co-authored-by: Srikanth Chekuri <[email protected]>
@sanketmehta28
Copy link
Member

Hi @ocelotl : Can you please close this as PR is meged?

@owais owais closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanketmehta28 sanketmehta28

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owais @sanketmehta28 @ashu658