Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django: Conditionally create SERVER spans #448

Closed
owais opened this issue Apr 15, 2021 · 4 comments
Closed

Django: Conditionally create SERVER spans #448

owais opened this issue Apr 15, 2021 · 4 comments
Assignees
@sanketmehta28
Labels
feature-request help wanted Extra attention is needed instrumentation

Comments

@owais
Copy link
Contributor

owais commented Apr 15, 2021

Part of #445
@owais owais added feature-request good first issue Good for newcomers help wanted Extra attention is needed instrumentation labels Apr 15, 2021
@owais owais removed the good first issue Good for newcomers label Oct 3, 2021
@sanketmehta28
Copy link
Member

Hi @owais : I would like to work on this as my first contribution to Opentelemetry.
Can you please assign it to me?

@owais
Copy link
Contributor Author

owais commented Nov 17, 2021

Assigned. @ashu658 was planning to work on #445 as well. Please coordinate so you don't work on the same tickets.

@sanketmehta28
Copy link
Member

Sure, We are from the same team. we will coordinate with each other.

@sanketmehta28 sanketmehta28 mentioned this issue Dec 14, 2021
Merged
4 tasks
ocelotl added a commit that referenced this issue Jan 7, 2022
@sanketmehta28 @ocelotl
Develop/condition server span django (#832)
d01efe5 
* Code changes and pytests for #448

* removing unnecessary imports

* removing unnecessary imports

* adding wsgi.py file to get the wsgi application object

* Revert "Updating personal fork from public repo"

* Revert "Updating personal fork from public repo"

* Revert "Updating personal fork from public repo"

* Revert "Updating personal fork from public repo"

* Changing the unit test case by removing WSGI instrumentation and make it from generalised

* removing unnecessary import statements

* Revert "Updating personal fork from public repo"

* resolving failed builds for lint and generate

* removing commented code

* removing blank line

* removed unused variable resp from test_middleware.py and modified the CHANGELOG.md with PR entry

* modified the CHANGELOG.md to removed unnecessary entry

* modified the CHANGELOG.md to add proper PR entry

Co-authored-by: Diego Hurtado <[email protected]>
@sanketmehta28
Copy link
Member

You can close this issue as the PR mentioned above is merged into main branch

@owais owais closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanketmehta28 sanketmehta28

Labels
feature-request help wanted Extra attention is needed instrumentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owais @sanketmehta28