Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We are running benchmark tests in CI #2659

Closed
ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #2660
Closed

We are running benchmark tests in CI #2659

ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #2660
Assignees
@ocelotl
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 3, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)

What happened?

We are running benchmark tests in CI

Steps to Reproduce

Run CI

Expected Result

No benchmark tests being run

Actual Result

Benchmark tests are being run

Additional context

It makes no sense to run them in CI unless these tests can fail in a useful manner, for example if they detect a drop in performance, right now they are not configured to do so. Also, we should not run the benchmark tests in CI, it is useless because they need a self-hosted runner in order to not be affected by server load and give meaningful results.

Would you like to implement a fix?

None
@ocelotl ocelotl added the bug Something isn't working label Jul 3, 2024
@ocelotl ocelotl self-assigned this Jul 3, 2024
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Jul 3, 2024
@ocelotl
Do not run benchmark tests in CI
3489c0e 
Fixes open-telemetry#2659
@ocelotl ocelotl mentioned this issue Jul 3, 2024
Merged
ocelotl added a commit that referenced this issue Jul 3, 2024
@ocelotl @xrmx
Do not run benchmark tests in CI (#2660)
fcc6751 
* Do not run benchmark tests in CI

Fixes #2659

* Add benchmark skip

* Update .github/workflows/test.yml

Co-authored-by: Riccardo Magliocchetti <[email protected]>

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not run benchmark tests in CI ocelotl/opentelemetry-python-contrib
1 participant
@ocelotl