Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib instrumentation failing after empty metric collection handling fix #2032

Closed
ocelotl opened this issue Nov 2, 2023 · 0 comments · Fixed by #2033
Closed

urllib instrumentation failing after empty metric collection handling fix #2032

ocelotl opened this issue Nov 2, 2023 · 0 comments · Fixed by #2033
Assignees
@ocelotl

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Nov 2, 2023

test_metric_uninstrument is failing after this.
@ocelotl ocelotl self-assigned this Nov 2, 2023
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Nov 2, 2023
@ocelotl
Fix urllib test case
a5aa10c 
This test case was failing after a fix to handle empty metric collection
cycles was added.

Fixes open-telemetry#2032
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Nov 2, 2023
@ocelotl
Fix failing urllib test case
90d79ae 
This test case started failing after a fix for the handling of empty
metric collection cycles was added to the core repo.

Fixes open-telemetry#2032
@ocelotl ocelotl mentioned this issue Nov 2, 2023
Merged
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Nov 3, 2023
@ocelotl
Fix failing test cases
cbf6e9b 
These test cases started failing after a fix for the handling of empty
metric collection cycles was added to the core repo.

Fixes open-telemetry#2032
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Nov 3, 2023
@ocelotl
Fix failing test cases
28f70a8 
These test cases started failing after a fix for the handling of empty
metric collection cycles was added to the core repo.

Fixes open-telemetry#2032
ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Nov 3, 2023
@ocelotl
Fix failing test cases
67ac36f 
These test cases started failing after a fix for the handling of empty
metric collection cycles was added to the core repo.

Fixes open-telemetry#2032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing test cases ocelotl/opentelemetry-python-contrib
1 participant
@ocelotl