Span name updated to follow semantic conventions to reduce cardinality (

#972)
open-telemetry · Aug 18, 2020 · c9a0fe7 · c9a0fe7
1 parent a43d088
commit c9a0fe7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/instrumentation/opentelemetry-instrumentation-aiohttp-client/CHANGELOG.md b/instrumentation/opentelemetry-instrumentation-aiohttp-client/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Updating span name to match semantic conventions
+  ([#972](https://github.com/open-telemetry/opentelemetry-python/pull/972))
+
 ## Version 0.12b0
 
 Released 2020-08-14

diff --git a/...strumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py b/...strumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
@@ -126,7 +126,7 @@ async def on_request_start(
     ):
         http_method = params.method.upper()
         if trace_config_ctx.span_name is None:
-            request_span_name = http_method
+            request_span_name = "HTTP {}".format(http_method)
         elif callable(trace_config_ctx.span_name):
             request_span_name = str(trace_config_ctx.span_name(params))
         else:

diff --git a/...ion/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py b/...ion/opentelemetry-instrumentation-aiohttp-client/tests/test_aiohttp_client_integration.py
@@ -118,7 +118,7 @@ def test_status_codes(self):
                 self.assert_spans(
                     [
                         (
-                            "GET",
+                            "HTTP GET",
                             (span_status, None),
                             {
                                 "component": "http",
@@ -192,7 +192,7 @@ def strip_query_params(url: yarl.URL) -> str:
         self.assert_spans(
             [
                 (
-                    "GET",
+                    "HTTP GET",
                     (StatusCanonicalCode.OK, None),
                     {
                         "component": "http",
@@ -232,7 +232,7 @@ async def do_request(url):
             self.assert_spans(
                 [
                     (
-                        "GET",
+                        "HTTP GET",
                         (expected_status, None),
                         {
                             "component": "http",
@@ -260,7 +260,7 @@ async def request_handler(request):
         self.assert_spans(
             [
                 (
-                    "GET",
+                    "HTTP GET",
                     (StatusCanonicalCode.DEADLINE_EXCEEDED, None),
                     {
                         "component": "http",
@@ -290,7 +290,7 @@ async def request_handler(request):
         self.assert_spans(
             [
                 (
-                    "GET",
+                    "HTTP GET",
                     (StatusCanonicalCode.DEADLINE_EXCEEDED, None),
                     {
                         "component": "http",