Fix net peer attribute for unix socket connection

open-telemetry · May 3, 2024 · be2c578 · be2c578
1 parent 1ee7261
commit be2c578
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/...ation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py b/...ation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py
@@ -29,7 +29,12 @@ def _extract_conn_attributes(conn_kwargs):
     }
     db = conn_kwargs.get("db", 0)
     attributes[SpanAttributes.DB_REDIS_DATABASE_INDEX] = db
-    try:
+    if "path" in conn_kwargs:
+        attributes[SpanAttributes.NET_PEER_NAME] = conn_kwargs.get("path", "")
+        attributes[SpanAttributes.NET_TRANSPORT] = (
+            NetTransportValues.OTHER.value
+        )
+    else:
         attributes[SpanAttributes.NET_PEER_NAME] = conn_kwargs.get(
             "host", "localhost"
         )
@@ -39,11 +44,6 @@ def _extract_conn_attributes(conn_kwargs):
         attributes[SpanAttributes.NET_TRANSPORT] = (
             NetTransportValues.IP_TCP.value
         )
-    except KeyError:
-        attributes[SpanAttributes.NET_PEER_NAME] = conn_kwargs.get("path", "")
-        attributes[SpanAttributes.NET_TRANSPORT] = (
-            NetTransportValues.OTHER.value
-        )
 
     return attributes