Fix traced_request_attrs (#473)

open-telemetry · Apr 29, 2021 · 43e0972 · 43e0972
1 parent 3ec7736
commit 43e0972
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,8 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python-contrib/compare/v0.200...HEAD)
 
 ### Changed
+
 - `opentelemetry-propagator-ot-trace` Use `TraceFlags` object in `extract`
   ([#472](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/472))
+- Set the `traced_request_attrs` of FalconInstrumentor by an argument correctly.
+  ([#473](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/473))
 
 ### Added
 - Move `opentelemetry-instrumentation` from core repository

diff --git a/...opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py b/...opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
@@ -154,7 +154,7 @@ def __init__(self, *args, **kwargs):
 
         trace_middleware = _TraceMiddleware(
             self._tracer,
-            kwargs.pop("traced_request_attributes", None),
+            kwargs.pop("traced_request_attributes", _traced_request_attrs),
             kwargs.pop("request_hook", None),
             kwargs.pop("response_hook", None),
         )
@@ -215,7 +215,7 @@ def __init__(
         response_hook=None,
     ):
         self.tracer = tracer
-        self._traced_request_attrs = _traced_request_attrs
+        self._traced_request_attrs = traced_request_attrs
         self._request_hook = request_hook
         self._response_hook = response_hook