lint

open-telemetry · Jul 26, 2024 · 3a06428 · 3a06428
1 parent c3502a7
commit 3a06428
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 26 deletions.
diff --git a/...opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py b/...opentelemetry-instrumentation-urllib/src/opentelemetry/instrumentation/urllib/__init__.py
@@ -178,10 +178,7 @@ def _instrument(self, **kwargs):
             schema_url=schema_url,
         )
 
-        histograms = _create_client_histograms(
-            meter,
-            sem_conv_opt_in_mode
-        )
+        histograms = _create_client_histograms(meter, sem_conv_opt_in_mode)
 
         _instrument(
             tracer,
@@ -254,7 +251,7 @@ def _instrumented_open_call(
 
         data = getattr(request, "data", None)
         request_size = 0 if data is None else len(data)
-        
+
         labels = {}
 
         _set_http_method(
@@ -297,9 +294,9 @@ def _instrumented_open_call(
                 if _report_old(sem_conv_opt_in_mode):
                     ver_ = str(getattr(result, "version", ""))
                     if ver_:
-                        labels[SpanAttributes.HTTP_FLAVOR] = (
-                            f"{ver_[:1]}.{ver_[:-1]}"
-                        )
+                        labels[
+                            SpanAttributes.HTTP_FLAVOR
+                        ] = f"{ver_[:1]}.{ver_[:-1]}"
 
             if exception is not None and _report_new(sem_conv_opt_in_mode):
                 span.set_attribute(ERROR_TYPE, type(exception).__qualname__)
@@ -309,13 +306,13 @@ def _instrumented_open_call(
                 labels,
                 _client_duration_attrs_old,
                 _client_duration_attrs_new,
-                sem_conv_opt_in_mode = _HTTPStabilityMode.DEFAULT,
+                sem_conv_opt_in_mode=_HTTPStabilityMode.DEFAULT,
             )
             duration_attrs_new = _filter_semconv_duration_attrs(
                 labels,
                 _client_duration_attrs_old,
                 _client_duration_attrs_new,
-                sem_conv_opt_in_mode = _HTTPStabilityMode.HTTP,
+                sem_conv_opt_in_mode=_HTTPStabilityMode.HTTP,
             )
 
             duration_attrs_old[SpanAttributes.HTTP_URL] = url
@@ -398,20 +395,28 @@ def _set_status_code_attribute(
     )
 
 
-def _create_client_histograms(meter, sem_conv_opt_in_mode = _HTTPStabilityMode.DEFAULT) -> Dict[str, Histogram]:
+def _create_client_histograms(
+    meter, sem_conv_opt_in_mode=_HTTPStabilityMode.DEFAULT
+) -> Dict[str, Histogram]:
     histograms = {}
     if _report_old(sem_conv_opt_in_mode):
-        histograms[MetricInstruments.HTTP_CLIENT_DURATION] = meter.create_histogram(
+        histograms[
+            MetricInstruments.HTTP_CLIENT_DURATION
+        ] = meter.create_histogram(
             name=MetricInstruments.HTTP_CLIENT_DURATION,
             unit="ms",
             description="Measures the duration of the outbound HTTP request",
         )
-        histograms[MetricInstruments.HTTP_CLIENT_REQUEST_SIZE] = meter.create_histogram(
+        histograms[
+            MetricInstruments.HTTP_CLIENT_REQUEST_SIZE
+        ] = meter.create_histogram(
             name=MetricInstruments.HTTP_CLIENT_REQUEST_SIZE,
             unit="By",
             description="Measures the size of HTTP request messages.",
         )
-        histograms[MetricInstruments.HTTP_CLIENT_RESPONSE_SIZE] = meter.create_histogram(
+        histograms[
+            MetricInstruments.HTTP_CLIENT_RESPONSE_SIZE
+        ] = meter.create_histogram(
             name=MetricInstruments.HTTP_CLIENT_RESPONSE_SIZE,
             unit="By",
             description="Measures the size of HTTP response messages.",
@@ -422,12 +427,12 @@ def _create_client_histograms(meter, sem_conv_opt_in_mode = _HTTPStabilityMode.D
             unit="s",
             description="Duration of HTTP client requests.",
         )
-        histograms[HTTP_CLIENT_REQUEST_BODY_SIZE] = create_http_client_request_body_size(
-            meter
-        )
-        histograms[HTTP_CLIENT_RESPONSE_BODY_SIZE] = create_http_client_response_body_size(
-            meter
-        )
+        histograms[
+            HTTP_CLIENT_REQUEST_BODY_SIZE
+        ] = create_http_client_request_body_size(meter)
+        histograms[
+            HTTP_CLIENT_RESPONSE_BODY_SIZE
+        ] = create_http_client_response_body_size(meter)
 
     return histograms
 

diff --git a/instrumentation/opentelemetry-instrumentation-urllib/tests/test_urllib_integration.py b/instrumentation/opentelemetry-instrumentation-urllib/tests/test_urllib_integration.py
@@ -286,9 +286,7 @@ def test_not_foundbasic_new_semconv(self):
 
         span = self.assert_span()
 
-        self.assertEqual(
-            span.attributes.get(HTTP_RESPONSE_STATUS_CODE), 404
-        )
+        self.assertEqual(span.attributes.get(HTTP_RESPONSE_STATUS_CODE), 404)
 
         self.assertIs(
             span.status.status_code,
@@ -315,9 +313,7 @@ def test_not_foundbasic_both_semconv(self):
         self.assertEqual(
             span.attributes.get(SpanAttributes.HTTP_STATUS_CODE), 404
         )
-        self.assertEqual(
-            span.attributes.get(HTTP_RESPONSE_STATUS_CODE), 404
-        )
+        self.assertEqual(span.attributes.get(HTTP_RESPONSE_STATUS_CODE), 404)
 
         self.assertIs(
             span.status.status_code,