Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an optional zero_threshold field to ExponentialHistogramDataPoint #441

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Introduce an optional zero_threshold field to ExponentialHistogramDataPoint #441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dfbac8
Introduce an optional `zero_threshold` field to `ExponentialHistogram…
kovrus Jan 3, 2023
a457b50
fixup! Introduce an optional `zero_threshold` field to `ExponentialHi…
kovrus Jan 4, 2023
76339de
fixup! fixup! Introduce an optional `zero_threshold` field to `Expone…
kovrus Jan 10, 2023
9bed2e7
Merge branch 'main' into issue-440
reyang Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Full list of differences found in [this compare](https://github.com/open-telemet

### Added

* Remove if no changes for this section before release.
* Introduce an optional `zero_threshold` field to `ExponentialHistogramDataPoint`.
[(#440)](https://github.com/open-telemetry/opentelemetry-proto/issues/440)

### Removed

Expand Down
7 changes: 7 additions & 0 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,13 @@ message ExponentialHistogramDataPoint {

// max is the maximum value over (start_time, end_time].
optional double max = 13;

// ZeroThreshold may be optionally set to convey the width of the
// zero region.
// When ZeroThreshold is unset or 0, zero count bucket stores
// values that cannot be expressed using the standard exponential formula as
// well as values that have been rounded to zero.
kovrus marked this conversation as resolved.
Show resolved Hide resolved
optional double zero_threshold = 14;
}

// SummaryDataPoint is a single data point in a timeseries that describes the
Expand Down