Replace attributes map by AttributeKeyValue pair list #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
bogdandrutu
approved these changes
Nov 7, 2019
SergeyKanzhelev
approved these changes
Nov 7, 2019
This is the first of commits that implements RFC0059 [1]. I will submit changes introduced in the RFC in separate PRs for easier review. This change is already benchmarked as part of the RFC, so I will not submit individual benchmarks with each PR. Note: this change has been thoroughly reviewed, commented and discussed as part of the RFC process. This commit merely implements part of the RFC. [1] - https://github.com/open-telemetry/oteps/blob/master/text/0059-otlp-trace-data-format.md
tigrannajaryan
force-pushed
the
feature/tigran/span_attributes
branch
from
94b64bd to
d0193bf
Compare
yurishkuro
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of commits that implements RFC0059 [1]. I will submit changes introduced
in the RFC in separate PRs for easier review.
This change is already benchmarked as part of the RFC, so I will not submit individual benchmarks
with each PR.
Note: this change has been thoroughly reviewed, commented and discussed as part of the RFC
process. This commit merely implements part of the RFC.
[1] - https://github.com/open-telemetry/oteps/blob/master/text/0059-otlp-trace-data-format.md