Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODOs from metrics.proto. #293

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Remove TODOs from metrics.proto. #293

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c2a20e
Remove TODOs from metrics.proto. Remaining todos are bugs against sp…
jsuereth Apr 6, 2021
86e8d34
fix merge conflicts.
jsuereth Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,6 @@ message Metric {
// described by http://unitsofmeasure.org/ucum.html.
string unit = 3;

// TODO: Decide if support for RawMeasurements (measurements recorded using
// the synchronous instruments) is necessary. It can be used to delegate the
// aggregation from the application to the agent/collector. See
// https://github.com/open-telemetry/opentelemetry-specification/issues/617

// Data determines the aggregation type (if any) of the metric, what is the
// reported value type for the data points, as well as the relatationship to
// the time interval over which they are reported.
Expand Down Expand Up @@ -447,7 +442,6 @@ message IntHistogramDataPoint {
// distribution of values in the histogram is unknown and only the total count and sum are known.

// explicit_bounds is the only supported bucket option currently.
// TODO: Add more bucket options.
jsuereth marked this conversation as resolved.
Show resolved Hide resolved

// explicit_bounds specifies buckets with explicitly defined bounds for values.
//
Expand Down Expand Up @@ -523,7 +517,6 @@ message HistogramDataPoint {
// distribution of values in the histogram is unknown and only the total count and sum are known.

// explicit_bounds is the only supported bucket option currently.
// TODO: Add more bucket options.
jsuereth marked this conversation as resolved.
Show resolved Hide resolved

// explicit_bounds specifies buckets with explicitly defined bounds for values.
//
Expand Down