Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Temporality with Kind; Type with ValueType #168

Closed
wants to merge 40 commits into from
Closed

Replace Temporality with Kind; Type with ValueType #168

Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
7dc68e8
Rough draft pre-comments
jmacd Jul 1, 2020
8838618
Comments and restoring order
jmacd Jul 1, 2020
907f253
Remove gen.go
jmacd Jul 1, 2020
01cdd17
metric_descriptor->descriptor
jmacd Jul 2, 2020
538e599
whitespace
jmacd Jul 2, 2020
5700d38
Define structure
jmacd Jul 2, 2020
58ecfab
Comments after @bogdandrutu and @MrAlias feedback
jmacd Jul 8, 2020
67f20c4
Revert data point changes, keep Kind & ValueType changes
jmacd Jul 14, 2020
e577247
Comment gen.go
jmacd Jul 14, 2020
50e0331
Checkpoint
jmacd Jul 14, 2020
0c3a7f6
Document each kind
jmacd Jul 15, 2020
c5f291a
Fix numbering
jmacd Jul 15, 2020
39e7967
One more #159 TODO
jmacd Jul 15, 2020
5e7fa7f
One more #159 TODO
jmacd Jul 15, 2020
88acc0c
Formatting
jmacd Jul 15, 2020
92ddee2
Undo generated files
jmacd Jul 15, 2020
82322a2
Upstream
jmacd Jul 15, 2020
e89503f
Remove go.mod
jmacd Jul 15, 2020
d870316
Comments
jmacd Jul 15, 2020
4a823d7
More comments on Kind
jmacd Jul 15, 2020
306d559
Format me
jmacd Jul 15, 2020
18271f2
Comments
jmacd Jul 16, 2020
d0186b0
Spelling
jmacd Jul 16, 2020
d081712
Grouping comment
jmacd Jul 16, 2020
20654a8
Asynchronous->Chronological
jmacd Jul 18, 2020
35bc2ba
Add missing comments
jmacd Jul 18, 2020
9d6210f
More comment on CHRONOLOGICAL
jmacd Jul 18, 2020
2855cec
More on CHRONOLOGICAL
jmacd Jul 18, 2020
9970a8b
Clarify ADDING|INSTANTANEOUS vs ADDING|DELTA
jmacd Jul 18, 2020
a551fb8
Clarify ADDING|INSTANTANEOUS vs ADDING|DELTA
jmacd Jul 18, 2020
ca17a32
Restore int64/double data points
jmacd Jul 20, 2020
bad082b
Restore int64/double data points
jmacd Jul 20, 2020
eeb489c
Make Monotonic a Structure
jmacd Jul 20, 2020
d0283cf
Generate code
jmacd Jul 20, 2020
ced5068
Upstream
jmacd Jul 20, 2020
fbcf615
Top of KindElement
jmacd Jul 23, 2020
376d80e
Rewrite KindElementdocs
jmacd Jul 23, 2020
bb9689f
Improve comments
jmacd Jul 23, 2020
15c7f92
Comment all Kind values
jmacd Jul 23, 2020
ab75b67
Merge 178
jmacd Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions gen/go/collector/metrics/v1/metrics_service.pb.gw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 48 additions & 0 deletions gen/go/collector/trace/v1/trace_service.pb.gw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading