Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for metric proto refactor #137

Closed
wants to merge 15 commits into from

Commits on Apr 15, 2020

  1. Proposal for metric proto refactor

    Update metric descriptor to contain information on the data qualities.
    This includes:
    
     - The meaning of the time interval measurements were made over is now
       described by the `interval` value.
     - The monotonic nature of the data is captured if known.
     - If the data values are restricted to a subset of numbers.
    
    The `SummaryDataPoint` and `HistogramDataPoint` were merged into a
    unified `Distribution` message that contains statistics about the
    observed population of values.
    
    Adds support for multiple histogram bucket definitions and adds a linear
    bucket definition message.
    
    Includes an explicit minimum and maximum for a `Distribution` (open-telemetry#122).
    
    Removes the exemplar code (open-telemetry#81). This can be added back in as a more
    generalized case now given the new `Data` structure of the Metrics. But,
    it has been left for a separate PR.
    
    Unifies the common parts of the previous `*DataPoints` into a unified
    `Data` message.
    
    This is not complete. It likely needs better names and it certainly
    needs comments.
    
    Related to open-telemetry#125
    Fixes to open-telemetry#81
    MrAlias committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    46c7c67 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Update opentelemetry/proto/metrics/v1/metrics.proto

    Co-Authored-By: Yuri Shkuro <[email protected]>
    MrAlias and yurishkuro authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    0f49829 View commit details
    Browse the repository at this point in the history
  2. Update opentelemetry/proto/metrics/v1/metrics.proto

    Co-Authored-By: Yuri Shkuro <[email protected]>
    MrAlias and yurishkuro authored Apr 17, 2020
    Configuration menu
    Copy the full SHA
    e573ee4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9cbe6ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9941f8e View commit details
    Browse the repository at this point in the history
  5. Update DELTA comment

    MrAlias committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    bfd1b5e View commit details
    Browse the repository at this point in the history
  6. Subset -> Domain

    MrAlias committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    05dec81 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    95e3136 View commit details
    Browse the repository at this point in the history
  8. Update metric data values

    Remove oneof and add Type field to the MetricDescriptor to specify what
    values to expect in the metric.data.
    MrAlias committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    acfaa4d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Break monotonic up

    MrAlias committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    33fef58 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Update docs for data labels

    Treat overlap as an error.
    MrAlias committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9727d7d View commit details
    Browse the repository at this point in the history
  2. Update docs

    MrAlias committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    116fad2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    275d831 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c97cf89 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Configuration menu
    Copy the full SHA
    5d071f1 View commit details
    Browse the repository at this point in the history