Skip to content

Commit

Permalink
Remove todos related to issues #188 and #189 (#194)
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu authored Aug 6, 2020
1 parent 63f37e5 commit f03768d
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions opentelemetry/proto/metrics/v1/metrics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,6 @@ message MetricDescriptor {

// If "true" means that the sum is monotonic.
bool is_monotonic = 3;

// TODO: Decide if knowing that the metric values are aggregated from raw
// measurements is important.
}

// Represents the type of a metric that is calculated by aggregating as a
Expand All @@ -203,12 +200,6 @@ message MetricDescriptor {

// Temporality is the temporal quality values of a metric have.
Temporality temporality = 2;

// TODO: Decide if knowing that the metric values are aggregated from raw
// measurements is important.

// TODO: Decide if knowing that the Sum is monotonic is important or not,
// may be derived from the buckets definition.
}

// Represents the type of a metric that is calculated by computing a summary
Expand All @@ -224,12 +215,6 @@ message MetricDescriptor {

// Temporality is the temporal quality values of a metric have.
Temporality temporality = 2;

// TODO: Decide if knowing that the metric values are aggregated from raw
// measurements is important.

// TODO: Decide if knowing that the Sum is monotonic is important or not,
// may be derived from the buckets definition.
}

// Type determines the aggregation type (if any) of the metric, what is the
Expand Down

0 comments on commit f03768d

Please sign in to comment.