Add building of OTLP bindings #1
Conversation
| withType<Jar>().configureEach { | ||
| manifest { | ||
| attributes( | ||
| "Automatic-Module-Name" to "io.opentelemetry.proto", |
| publishing { | ||
| publications { | ||
| register<MavenPublication>("mavenPublication") { | ||
| groupId = "io.opentelemetry.proto" |
There was a problem hiding this comment.
@jkwatson The coordinates don't collide because this group is different.
There was a problem hiding this comment.
cool. yes, you are correct. thanks for re-iterating!
There was a problem hiding this comment.
so the maven coordinates end up as io.opentelemetry.proto:opentelemetry-proto, correct?
| } | ||
|
|
||
| pom { | ||
| name.set("OpenTelemetry Protocol") |
| id("otel.publish-conventions") | ||
| } | ||
|
|
||
| description = "Java Bindings for the OpenTelemetry Protocol (OTLP)" |
| @@ -0,0 +1,14 @@ | |||
| version = 0.9.0-alpha | |||
There was a problem hiding this comment.
the latest proto version is 0.10.0. Shouldn't we align with that initially, if this is going to be aligned with the proto releases?
There was a problem hiding this comment.
I figured we can release 0.9 first, remove proto from the SDK repo while then bumping this repo to 0.10. How does that sound?
There was a problem hiding this comment.
I think that it probably doesn't matter to wait for the SDK, unless we're using identical maven coordinates. I don't think we can use identical maven coordinates, since the versions will collide in the 0.10.0 release: https://search.maven.org/artifact/io.opentelemetry/opentelemetry-proto/0.10.0/jar.
There was a problem hiding this comment.
I wouldn't wait for the SDK for anything here - I figured it's worth publishing both 0.9.0 and 0.10.0 here since it's easy, release, change one line, release once more. Having 0.9.0 would allow us to swap it in for the current proto module in the SDK without worry of any changes. Perhaps it's too much worry though given we only use it in tests there now.
|
What are the resulting maven coordinates of this publication? I assume they don't collide with the one that we've been publishing in opentelemetry-java? |
| # This file controls who is tagged for review for any given pull request. | ||
|
|
||
| # For anything not explicitly taken by someone else: | ||
| * @anuraaga @bogdandrutu @jkwatson |
There was a problem hiding this comment.
we should find some maintainers for this repo who care about having an independent proto artifact. :)
There was a problem hiding this comment.
Hoping this will be a pretty trivial repo after the initial commits :)
No description provided.