Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CorrelationContext to Baggage #346

Conversation

bobstrecansky
Copy link
Collaborator

Changing CorrelationContext -> Baggage as per the spec

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #346 (4f55e69) into main (bbc09fb) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #346      +/-   ##
============================================
- Coverage     94.09%   93.81%   -0.28%     
+ Complexity      552      548       -4     
============================================
  Files            49       49              
  Lines          1338     1343       +5     
============================================
+ Hits           1259     1260       +1     
- Misses           79       83       +4     
Impacted Files Coverage Δ
sdk/Baggage.php 96.00% <100.00%> (ø)
contrib/ZipkinToNewrelic/Exporter.php 91.48% <0.00%> (-8.52%) ⬇️
contrib/Otlp/Exporter.php 97.36% <0.00%> (ø)
contrib/Zipkin/Exporter.php 100.00% <0.00%> (ø)
contrib/Newrelic/Exporter.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc09fb...4f55e69. Read the comment docs.

@bobstrecansky
Copy link
Collaborator Author

@zsistla @Fahmy-Mohammed @beniamin for review please.

Copy link
Contributor

@zsistla zsistla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :)

@bobstrecansky bobstrecansky merged commit e20956f into open-telemetry:main Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants