Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Versioning Rationale #232

Merged

Conversation

bobstrecansky
Copy link
Collaborator

Initial Semantic Versioning Rationale document.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #232 (bcc8577) into master (094333d) will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
+ Coverage     92.40%   92.98%   +0.58%     
- Complexity      353      382      +29     
============================================
  Files            38       40       +2     
  Lines           829      898      +69     
============================================
+ Hits            766      835      +69     
  Misses           63       63              
Impacted Files Coverage Δ Complexity Δ
sdk/Trace/TracerProvider.php 93.10% <0.00%> (-0.45%) 9.00% <0.00%> (ø%)
sdk/Resource/ResourceInfo.php 100.00% <0.00%> (ø) 9.00% <0.00%> (+1.00%)
contrib/Otlp/SpanConverter.php 100.00% <0.00%> (ø) 11.00% <0.00%> (ø%)
contrib/Zipkin/SpanConverter.php 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
sdk/Trace/PropagationMap.php 100.00% <0.00%> (ø) 13.00% <0.00%> (?%)
sdk/Trace/TraceContext.php 100.00% <0.00%> (ø) 13.00% <0.00%> (?%)
sdk/Trace/Tracer.php 92.85% <0.00%> (+0.26%) 21.00% <0.00%> (+1.00%)
sdk/Trace/Span.php 89.36% <0.00%> (+0.35%) 39.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094333d...bcc8577. Read the comment docs.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is nit-picky. Great job!

docs/versioning.md Outdated Show resolved Hide resolved
docs/versioning.md Outdated Show resolved Hide resolved
docs/versioning.md Outdated Show resolved Hide resolved
docs/versioning.md Outdated Show resolved Hide resolved
docs/versioning.md Show resolved Hide resolved
docs/versioning.md Outdated Show resolved Hide resolved
docs/versioning.md Outdated Show resolved Hide resolved
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me modulo the one comment I made

docs/versioning.md Show resolved Hide resolved
@bobstrecansky bobstrecansky merged commit cc1d882 into open-telemetry:master Jan 7, 2021
@bobstrecansky bobstrecansky deleted the semantic_versioning branch January 7, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants