add sdk-config 0.3 support for key/value headers and attributes #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- headers and attributes are now arrays with `key` and `value` elements - headers can optionally contain a `headers_list` element which supports a lower-priority CSV of key/value entries - attributes can optionally contain an `attributes_list` element which supports a lower-priority CSV of key/value entries
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
============================================
- Coverage 73.59% 73.26% -0.34%
Complexity 2685 2685
============================================
Files 387 387
Lines 7977 8009 +32
============================================
- Hits 5871 5868 -3
- Misses 2106 2141 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlp.php
Outdated
Show resolved
Hide resolved
Nevay
reviewed
Nov 13, 2024
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlp.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Bachert <[email protected]>
|
@open-telemetry/php-approvers I think this is ready for review now. |
Nevay
reviewed
Nov 18, 2024
src/Config/SDK/ComponentProvider/Logs/LogRecordExporterOtlp.php
Outdated
Show resolved
Hide resolved
ChrisLightfootWild
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyandvalueelementsheaders_listelement which supports a lower-priority CSV of key/value entriesattributes_listelement which supports a lower-priority CSV of key/value entriesRelated: #1423