Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to publish phpdoc to github pages #1418

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Oct 25, 2024

Follow-up to #1378 and #1385:

I did some investigation how to best publish the API documentation for PHP. Initially I was hoping that we can serve these pages through netlify (the service we use to publish opentelemetry.io), unfrotunately I ran into some limitations in my experiment, that I could not resolve, see: open-telemetry/opentelemetry.io#5413

Therefore I suggest to publish the pages to github via the workflow in this PR. This will create a page similar to

https://svrnm.github.io/opentelemetry-php/

(it will then be named https://open-telemetry.github.io/opentelemetry-php/)

We can then link this page from the website here: https://opentelemetry.io/docs/languages/#api-references and from within the navigation tree of the PHP language specific documentation.

Workflow run example:

https://github.com/svrnm/opentelemetry-php/actions/runs/11512969202/job/32048846572

cc @open-telemetry/docs-approvers

@svrnm svrnm requested a review from a team as a code owner October 25, 2024 06:32
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit 1b5a0b3
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/671b3b96504491000823112e

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (93f2068) to head (1b5a0b3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1418      +/-   ##
============================================
- Coverage     73.63%   73.55%   -0.08%     
  Complexity     2683     2683              
============================================
  Files           387      387              
  Lines          7975     7975              
============================================
- Hits           5872     5866       -6     
- Misses         2103     2109       +6     
Flag Coverage Δ
8.1 73.24% <ø> (-0.14%) ⬇️
8.2 73.50% <ø> (+0.02%) ⬆️
8.3 73.42% <ø> (-0.05%) ⬇️
8.4 73.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f2068...1b5a0b3. Read the comment docs.

@brettmc brettmc merged commit 1aae9dd into open-telemetry:main Oct 27, 2024
13 of 14 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Oct 27, 2024

@svrnm merged. The workflow looks to have completed successfully, but I don't see any generated pages.... https://github.com/open-telemetry/opentelemetry-php/actions/runs/11543950343

@svrnm
Copy link
Member Author

svrnm commented Oct 28, 2024

@brettmc have you enabled GitHub pages in the repo settings?

@brettmc
Copy link
Collaborator

brettmc commented Oct 28, 2024

Screenshot from 2024-10-29 09-38-57
@svrnm yes, and it indicates that something was deployed there. But now that I'm looking more closely at the job output it looks like we've got a competing job which might be publishing junk and clobbering the output you've created. I can't find any evidence in our repo of what that job might be or where it's defined though 🤔

@brettmc
Copy link
Collaborator

brettmc commented Oct 28, 2024

Oh, I think I found it. Pages are configured to auto-generate:
Screenshot from 2024-10-29 10-10-46
I'll turn that off and see what happens...

@brettmc
Copy link
Collaborator

brettmc commented Oct 29, 2024

I also notice now that the new workflow file doesn't have an extension. I think .yaml or .yml extension is required?

@svrnm
Copy link
Member Author

svrnm commented Oct 29, 2024

Thanks for investigating what the issue is!

I also notice now that the new workflow file doesn't have an extension. I think .yaml or .yml extension is required?

Oh yes, my bad! The issue is that I had to test the workflow on the main branch of my fork so I copied and pasted the final version into a branch but forgot the .yml 🤦‍♂️

svrnm added a commit to svrnm/opentelemetry-php that referenced this pull request Nov 4, 2024
follow up to open-telemetry#1418, where I named the file without the required YML suffix
brettmc pushed a commit that referenced this pull request Nov 5, 2024
- follow up to #1418, where I named the file without the required YML suffix
- Do not run on pull requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants