-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow to publish phpdoc to github pages #1418
Conversation
✅ Deploy Preview for opentelemetry-php canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
============================================
- Coverage 73.63% 73.55% -0.08%
Complexity 2683 2683
============================================
Files 387 387
Lines 7975 7975
============================================
- Hits 5872 5866 -6
- Misses 2103 2109 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@svrnm merged. The workflow looks to have completed successfully, but I don't see any generated pages.... https://github.com/open-telemetry/opentelemetry-php/actions/runs/11543950343 |
@brettmc have you enabled GitHub pages in the repo settings? |
|
I also notice now that the new workflow file doesn't have an extension. I think .yaml or .yml extension is required? |
Thanks for investigating what the issue is!
Oh yes, my bad! The issue is that I had to test the workflow on the main branch of my fork so I copied and pasted the final version into a branch but forgot the .yml 🤦♂️ |
follow up to open-telemetry#1418, where I named the file without the required YML suffix
- follow up to #1418, where I named the file without the required YML suffix - Do not run on pull requests
Follow-up to #1378 and #1385:
I did some investigation how to best publish the API documentation for PHP. Initially I was hoping that we can serve these pages through netlify (the service we use to publish opentelemetry.io), unfrotunately I ran into some limitations in my experiment, that I could not resolve, see: open-telemetry/opentelemetry.io#5413
Therefore I suggest to publish the pages to github via the workflow in this PR. This will create a page similar to
https://svrnm.github.io/opentelemetry-php/
(it will then be named https://open-telemetry.github.io/opentelemetry-php/)
We can then link this page from the website here: https://opentelemetry.io/docs/languages/#api-references and from within the navigation tree of the PHP language specific documentation.
Workflow run example:
https://github.com/svrnm/opentelemetry-php/actions/runs/11512969202/job/32048846572
cc @open-telemetry/docs-approvers