fix withspan handler nullable + example #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brettmc
commented
Sep 6, 2024
brettmc
commented
- class is nullable for pre hooks
- add phpt tests for withspan and its interaction with auto root span
- class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
============================================
+ Coverage 74.07% 74.14% +0.06%
Complexity 2666 2666
============================================
Files 385 385
Lines 7638 7638
============================================
+ Hits 5658 5663 +5
+ Misses 1980 1975 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisLightfootWild
approved these changes
Sep 6, 2024
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Oct 2, 2024
- class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span
bobstrecansky
pushed a commit
that referenced
this pull request
Oct 2, 2024
* 8.4: fixing some implicit nullable params * fix withspan handler nullable + example (#1377) - class is nullable for pre hooks - add phpt tests for withspan and its interaction with auto root span * fix: update references to logging exporter (#1383) This exporter has been replaced by the debug exporter and will be removed soon. Related to open-telemetry/opentelemetry-collector#11037 Signed-off-by: Alex Boten <[email protected]> * fix: Update collector tag in example to latest (#1384) Follow-up from #1383. Debug exporter isn't available until v0.86.0, so this new configuration throws an error when trying to run the collector. `Error: cannot unmarshal the configuration: unknown exporters type "debug" for "debug"` Instead of setting to v0.86.0, I noticed the other docker files omitted the tag (so latest is pulled). I just updated this to match. * Remove `MeterInterface::isEnabled()` and fix meter config re-enabling (#1387) * Update SPI dependency to v1. (#1388) * Fix README badges. (#1389) * add phpDocumentor instructions to Makefile (#1385) * add phpDocumentor instructions to Makefile Signed-off-by: svrnm <[email protected]> * update DEVELOPMENT.md Signed-off-by: svrnm <[email protected]> --------- Signed-off-by: svrnm <[email protected]> * Update README.md (#1344) * Fix `IncompatibleReturnValueException` in `MessageFactoryTest` (#1392) PSR7 `RequestInterface::getUri()` must return `UriInterface`, not `string`; explicit typehint was added in `2.0`. * more implicit nulls --------- Signed-off-by: Alex Boten <[email protected]> Signed-off-by: svrnm <[email protected]> Co-authored-by: Alex Boten <[email protected]> Co-authored-by: Jamie Danielson <[email protected]> Co-authored-by: Tobias Bachert <[email protected]> Co-authored-by: Chris Lightfoot-Wild <[email protected]> Co-authored-by: Severin Neumann <[email protected]> Co-authored-by: Oleg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.