Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up shell scripts #1269

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Clean up shell scripts #1269

merged 2 commits into from
Apr 2, 2024

Conversation

johnbley
Copy link
Member

@johnbley johnbley commented Apr 2, 2024

  • Use set -e rather than repeatedly checking for errors
  • Apply suggestion from shellcheck --severity=warning to properly quote backtick result
  • Add CI step to run shellcheck --severity=warning

@johnbley johnbley requested a review from a team April 2, 2024 19:40
Copy link

welcome bot commented Apr 2, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (bb9eb40) to head (f456507).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1269   +/-   ##
=========================================
  Coverage     77.25%   77.25%           
  Complexity     2230     2230           
=========================================
  Files           321      321           
  Lines          6682     6682           
=========================================
  Hits           5162     5162           
  Misses         1520     1520           
Flag Coverage Δ
8.1 77.25% <ø> (ø)
8.2 77.25% <ø> (ø)
8.3 77.25% <ø> (ø)
8.4 77.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb9eb40...f456507. Read the comment docs.

@brettmc brettmc merged commit e44f5a9 into open-telemetry:main Apr 2, 2024
10 checks passed
@brettmc
Copy link
Collaborator

brettmc commented Apr 2, 2024

Thanks, @johnbley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants