Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade psalm to v5 #1246

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Mar 4, 2024

upgrade to the latest version of psalm, and fix/suppress all of the new issues it identifies.

upgrade to the latest version of psalm, and fix/suppress all of the new issues it identifies.
@brettmc brettmc requested a review from a team March 4, 2024 04:53
@brettmc brettmc added this to the 1.1 milestone Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (f798bb6) to head (9b5ce5a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1246   +/-   ##
=========================================
  Coverage     84.62%   84.62%           
  Complexity     2136     2136           
=========================================
  Files           284      284           
  Lines          6054     6054           
=========================================
  Hits           5123     5123           
  Misses          931      931           
Flag Coverage Δ
8.0 84.57% <100.00%> (ø)
8.1 84.60% <100.00%> (ø)
8.2 84.60% <100.00%> (ø)
8.3 84.60% <100.00%> (ø)
8.4 84.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Baggage/Propagation/Parser.php 100.00% <ø> (ø)
src/API/Behavior/Internal/LogWriter/Formatter.php 100.00% <ø> (ø)
src/Context/ContextKey.php 100.00% <ø> (ø)
src/Contrib/Grpc/GrpcTransportFactory.php 71.62% <ø> (ø)
src/SDK/Common/Attribute/Attributes.php 100.00% <ø> (ø)
src/SDK/Common/Configuration/Parser/MapParser.php 94.44% <ø> (ø)
src/SDK/Common/Exception/StackTraceFormatter.php 0.00% <ø> (ø)
src/SDK/Common/Export/Http/PsrTransport.php 94.44% <ø> (ø)
src/SDK/Common/Export/Http/PsrUtils.php 92.42% <ø> (ø)
src/SDK/Common/Future/ErrorFuture.php 100.00% <ø> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f798bb6...9b5ce5a. Read the comment docs.

@bobstrecansky bobstrecansky merged commit bb07aca into open-telemetry:main Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants